Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: aws_finspace_kx_database #31803

Merged
merged 28 commits into from
Jun 8, 2023
Merged

[New Resource]: aws_finspace_kx_database #31803

merged 28 commits into from
Jun 8, 2023

Conversation

kavan-aws
Copy link
Contributor

@kavan-aws kavan-aws commented Jun 6, 2023 •
edited
Loading

Description

This pull request introduces the finspace_kx_database resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.

Relations

Relates #22658

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKxDatabase PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDatabase_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxDatabase_basic
=== PAUSE TestAccFinSpaceKxDatabase_basic
=== CONT  TestAccFinSpaceKxDatabase_basic
--- PASS: TestAccFinSpaceKxDatabase_basic (849.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	876.898s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDatabase'  -timeout 180m
=== RUN   TestAccFinSpaceKxDatabase_disappears
=== PAUSE TestAccFinSpaceKxDatabase_disappears
=== RUN   TestAccFinSpaceKxDatabase_description
=== PAUSE TestAccFinSpaceKxDatabase_description
=== CONT  TestAccFinSpaceKxDatabase_description
=== CONT  TestAccFinSpaceKxDatabase_disappears
--- PASS: TestAccFinSpaceKxDatabase_disappears (1536.99s)
--- PASS: TestAccFinSpaceKxDatabase_description (1627.43s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1651.878s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDatabase_tags'  -timeout 180m
=== RUN   TestAccFinSpaceKxDatabase_tags
=== PAUSE TestAccFinSpaceKxDatabase_tags
=== CONT  TestAccFinSpaceKxDatabase_tags
--- PASS: TestAccFinSpaceKxDatabase_tags (1216.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1241.325s
...

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. labels Jun 6, 2023
@kavan-aws
Copy link
Contributor Author

_tags acceptance test output not shown above since still working through some test issues brought about by switch to transparent tagging, as discussed with @jar-b. Tags count is showing one less than it should (0 instead of 1 or 1 instead of 2).

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2023
@jar-b jar-b added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2023
kavan-aws and others added 15 commits June 7, 2023 16:18
@kavan-aws
Update kx_database_test.go
408aca3
@jar-b
r/aws_finspace_kx_database: alphabetize attributes
d96c734
@jar-b
r/aws_finspace_kx_database: crud handlers return diags
0efbe5b
@jar-b
r/aws_finspace_kx_database: simplify update
860716d
@jar-b
r/aws_finspace_kx_database: find by id to support import
43b406d
@jar-b
r/aws_finspace_kx_database(test): terrafmt
ee04317
@kavan-aws
Merge branch 'hashicorp:main' into f-finspace_kx_database
ab82ff9
@kavan-aws
Update kx_database_test.go
b33a2c4
@kavan-aws
Update kx_database_test.go
03e1a67
@jar-b
r/aws_finspace_kx_database(docs): add import section, document id att…
10e7dce 
…ribute
@jar-b
r/aws_finspace_kx_database(docs): use standard tags/tags_all descript…
3a31e13 
…ions
@jar-b
r/aws_finspace_kx_database: import support
ddae2fe
@jar-b
r/aws_finspace_kx_database(test): add base config
56b7260
@jar-b
chore: changelog
3568a4d
@jar-b
r/aws_finspace_kx_database(test): add ctx to check funcs
6073c27
@jar-b jar-b changed the title F finspace kx database [New Resource]: aws_finspace_kx_database Jun 8, 2023
jar-b
jar-b approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=finspace TESTS=TestAccFinSpaceKxDatabase_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDatabase_'  -timeout 180m

--- PASS: TestAccFinSpaceKxDatabase_disappears (1257.83s)
--- PASS: TestAccFinSpaceKxDatabase_basic (1258.82s)
--- PASS: TestAccFinSpaceKxDatabase_description (1268.08s)
--- PASS: TestAccFinSpaceKxDatabase_tags (1339.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1342.800s

@jar-b jar-b merged commit fefb4b7 into hashicorp:main Jun 8, 2023
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 8, 2023
@jar-b
Copy link
Member

jar-b commented Jun 8, 2023

Thanks for your contribution, @kavan-aws! 👍

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kavan-aws @jar-b